fix: reject excessive AllocRingBuffer allocations#149
Open
Sieger9303 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #148 .
Hi, thanks for maintaining this crate.
AllocRingBuffer::newallocates a heap buffer based on the requested capacity rounded up to the next power of two. Very large capacities can produce a valid layout while still requesting an impractically large allocation, which can lead to resource exhaustion under tools such as Miri.This PR adds a lightweight upper-bound check on the computed allocation size before calling the allocator. The public API shape is unchanged; excessive capacities now fail predictably with a Rust panic instead of reaching the raw allocation path.