Skip to content

Fix GenMol local Docker setup - #42

Merged
ohadmo merged 7 commits into
mainfrom
omosafi/genmol-nim-fix
Sep 30, 2026
Merged

ohadmo merged 7 commits into
mainfrom
omosafi/genmol-nim-fix

Conversation

@ohadmo

@ohadmo ohadmo commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
@ohadmo

ohadmo commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

@greptile-apps

greptile-apps Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[Low risk] Documentation and evaluation config for a molecule generation skill.

The PR appears safe to merge; the remaining skill-card metadata issue is non-blocking.

Findings

  1. P2 Structured outputs omitted ▶

Summary

The PR updates GenMol’s local Docker guidance, adds an active evaluation for setup instructions, and refreshes the published benchmark, skill card, and signature.

  • The signature’s checked resource digests match the current payload.
  • The skill card should continue to describe the structured outputs used by the skill.

Reviews (6) · Last reviewed commit: "Attach NVSkills validation signatures"

Comment thread skills/bionemo-agent-toolkit/skills/genmol-nim/SKILL.md
Comment thread nim-skills/genmol-nim/evals/evals.json Outdated
Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
Comment thread skills/bionemo-agent-toolkit/skills/genmol-nim/skill-card.md Outdated
Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
@ohadmo

ohadmo commented Sep 30, 2026

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

Comment thread nim-skills/genmol-nim/evals/evals.json
Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
@ohadmo

ohadmo commented Sep 30, 2026

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
@ohadmo

ohadmo commented Sep 30, 2026

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
Comment on lines +36 to 37
**Output Type(s):** [Shell commands, Code, Files, Configuration instructions] <br>
**Output Format:** [Markdown with inline Python and bash code blocks] <br>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Structured outputs omitted The updated card describes only a Markdown answer, but the skill still calls the GenMol API, parses its JSON response, and instructs agents to save ranked molecules in a .smi file. Readers using the card to plan downstream processing may miss those outputs.

Suggested change
**Output Type(s):** [Shell commands, Code, Files, Configuration instructions] <br>
**Output Format:** [Markdown with inline Python and bash code blocks] <br>
**Output Type(s):** [API Calls, Shell commands, Code, Files, Configuration instructions] <br>
**Output Format:** [JSON API responses, Markdown with inline Python and bash code blocks, and tabular .smi files] <br>

Knowledge Base Used: Plugin packaging and distribution

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@ohadmo
ohadmo merged commit a92a769 into main Sep 30, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants