Skip to content

RFdiffusion NIM signing - #44

Merged
ohadmo merged 2 commits into
mainfrom
omosafi/rfdiffusion-nim
Sep 30, 2026
Merged

ohadmo merged 2 commits into
mainfrom
omosafi/rfdiffusion-nim

Conversation

@ohadmo

@ohadmo ohadmo commented Sep 30, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@ohadmo ohadmo changed the title Convert RFdiffusion evaluation assertions to strings RFdiffusion NIM signing Sep 30, 2026
@greptile-apps

greptile-apps Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 4/5

[Medium risk] Adds evaluation benchmarks and signing metadata for a protein design skill.

The PR should not merge until the signature attests the files at their actual distributed paths.

Findings

  1. P1 Signature names nonexistent file ▶

Summary

The PR reformats RFDiffusion evaluation assertions, adjusts wording in both skill copies, and adds a benchmark, skill card, and signing artifact to the aggregate skill. The signing artifact needs regeneration because an attested resource path does not match the distributed tree.

Reviews (3) · Last reviewed commit: "Attach NVSkills validation signatures"

Comment thread nim-skills/rfdiffusion-nim/SKILL.md Outdated
@ohadmo
ohadmo force-pushed the omosafi/rfdiffusion-nim branch from 9e0722d to 4acabf0 Compare September 30, 2026 17:47
Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
@ohadmo
ohadmo force-pushed the omosafi/rfdiffusion-nim branch from 4acabf0 to 0558619 Compare September 30, 2026 17:47
@ohadmo

ohadmo commented Sep 30, 2026

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
Comment thread skills/bionemo-agent-toolkit/skills/rfdiffusion-nim/skill.oms.sig
@ohadmo
ohadmo merged commit d08ea0a into main Sep 30, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants