Skip to content

Improve copyright year range handling - #290

Merged
scal444 merged 1 commit into
NVIDIA-BioNeMo:mainfrom
scal444:issue-161-copyright-year-ranges
Sep 11, 2026
Merged

scal444 merged 1 commit into
NVIDIA-BioNeMo:mainfrom
scal444:issue-161-copyright-year-ranges

Conversation

@scal444

@scal444 scal444 commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Implements #161

@scal444

scal444 commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile-apps please review the changes to apply_copyright.sh, they're the only non-automated bit

@scal444
scal444 requested a review from evasnow1992 September 10, 2026 12:05
@greptile-apps

greptile-apps Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with the previous copyright-fixer issue fully addressed and no new actionable failures identified.

Summary

  • Accepts and replaces both single years and year ranges.
  • Clamps imported pre-project history to the 2025 project baseline.
  • Includes the current year for pending working-tree changes so local fixes agree with subsequent CI checks.
  • The previously reported stale-year fixer issue is resolved.

Reviews (2) · Last reviewed commit: "Improve copyright year range handling"

Comment thread admin/apply_copyright.sh
@scal444
scal444 force-pushed the issue-161-copyright-year-ranges branch from 865a5c9 to 24cd0e8 Compare September 10, 2026 12:18
@scal444

scal444 commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile-apps please re-review copyright application

@evasnow1992 evasnow1992 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.

@scal444
scal444 force-pushed the issue-161-copyright-year-ranges branch from 24cd0e8 to 386443c Compare September 10, 2026 16:01
@greptile-apps

greptile-apps Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Too many files changed for review (170 files, 100 file limit).

Bypass the limit by tagging @greptile-apps to review.

@scal444
scal444 force-pushed the issue-161-copyright-year-ranges branch from 386443c to fcf76e0 Compare September 10, 2026 19:37
@scal444
scal444 merged commit 6e174c2 into NVIDIA-BioNeMo:main Sep 11, 2026
14 checks passed
@scal444
scal444 deleted the issue-161-copyright-year-ranges branch September 18, 2026 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants