Add clang-tidy correctness CI

[scal444]

Updates to use clang-tidy 22 which has limited CUDA support.

We're starting with correctness-only items, then will expand with coverage and fixes .

Only true bug fixed in this diff is an unlikely overrun adding 1 to maxBatchSize BEFORE converting to size_t instead of after. The rest are defensive, or needed to get Clang CUDA compiling.

[greptile-apps]

Confidence Score: 5/5

The PR appears safe to merge, with no outstanding correctness, security, or repository-rule violations identified.

Summary

Adds correctness-focused clang-tidy 22 analysis for host C++ and CUDA code.

• Introduces a pinned static-analysis CI workflow and CUDA compile-database conversion tooling.
• Narrows clang-tidy configuration to analyzer and bug-prone correctness checks.
• Resolves analyzer findings and compatibility issues across C++ and CUDA sources.
• Corrects integer conversion ordering when allocating and calculating consolidated substructure buffers.
• Removes an optional local pre-push hook while retaining CI enforcement.

_{Reviews (3) · Last reviewed commit: "Add clang-tidy correctness CI"}

[evasnow1992]

Thank you adding this additional gate. Changes look good to me.