Skip to content

Enable developer warnings in C++ CI - #309

Merged
scal444 merged 3 commits into
NVIDIA-BioNeMo:mainfrom
scal444:codex/warning-gate
Sep 18, 2026
Merged

scal444 merged 3 commits into
NVIDIA-BioNeMo:mainfrom
scal444:codex/warning-gate

Conversation

@scal444

@scal444 scal444 commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@greptile-apps

greptile-apps Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with no outstanding correctness, security, or repository-rule issues identified.

Summary

Enables developer warning flags in the C++ CI build and resolves the resulting warnings without changing intended runtime behavior.

  • Enables NVMOLKIT_EXTRA_DEV_FLAGS in the C++ build-and-test workflow.
  • Avoids a Boost.Python compiler false positive by using a named boolean extractor.
  • Makes MMFF clamp-bound types explicit.
  • Marks conditionally used CUDA locals as potentially unused.

Reviews (2) · Last reviewed commit: "Mark optional CUDA diagnostics as unused"

@evasnow1992 evasnow1992 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for switching on the warnings in C++ CI. Changes look good to me.

@scal444
scal444 merged commit 9f410f4 into NVIDIA-BioNeMo:main Sep 18, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants