Skip to content

Expand ruff checks, and apply non-formatting checks to CI - #311

Merged
scal444 merged 10 commits into
NVIDIA-BioNeMo:mainfrom
scal444:codex/ruff-fi-ci
Sep 19, 2026
Merged

scal444 merged 10 commits into
NVIDIA-BioNeMo:mainfrom
scal444:codex/ruff-fi-ci

Conversation

@scal444

@scal444 scal444 commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@greptile-apps

greptile-apps Bot commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with no outstanding correctness, security, or repository-rule violations identified.

Summary

This PR broadens Ruff’s configured lint categories and applies lint checks alongside formatting in CI.

  • Updates the Ruff helper to run safe lint fixes locally and non-mutating checks in dry-run mode.
  • Cleans up newly detected lint violations across the Python package, tests, and benchmarks.
  • Preserves the order-sensitive native converter bootstrap sequence in nvmolkit/types.py.

Reviews (4) · Last reviewed commit: "Clarify native converter import ordering"

@scal444
scal444 requested a review from evasnow1992 September 18, 2026 15:21
Comment thread nvmolkit/types.py Outdated

@evasnow1992 evasnow1992 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. One non-blocker comment.

@scal444
scal444 merged commit 719330e into NVIDIA-BioNeMo:main Sep 19, 2026
16 checks passed
@scal444
scal444 deleted the codex/ruff-fi-ci branch September 23, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants