Skip to content

Enable most ruff checks - #315

Merged
scal444 merged 5 commits into
NVIDIA-BioNeMo:mainfrom
scal444:codex/ruff-followup
Sep 22, 2026
Merged

scal444 merged 5 commits into
NVIDIA-BioNeMo:mainfrom
scal444:codex/ruff-followup

Conversation

@scal444

@scal444 scal444 commented Sep 19, 2026 •

Copy link
Copy Markdown
Collaborator

No description provided.

@greptile-apps

greptile-apps Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; no actionable behavioral, security, or repository-rule violations were identified.

Summary

This PR enables additional Ruff rule families and applies lint-driven, behavior-preserving cleanups across library code, benchmarks, and tests.

  • Expands Ruff coverage to async, Bugbear, performance, Pylint warnings, return, and simplification checks.
  • Refactors MCS pair construction and TFD benchmark validation without changing ordering or result semantics.
  • Tightens TFD exception tests and simplifies test factories, parsing helpers, and benchmark callbacks.

Reviews (1) · Last reviewed commit: "Localize intentional Ruff suppressions"

@scal444 scal444 changed the title Codex/ruff followup Enable most ruff checks Sep 19, 2026
@scal444
scal444 requested a review from evasnow1992 September 19, 2026 14:04

@evasnow1992 evasnow1992 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Thanks!

@scal444
scal444 merged commit 64acff1 into NVIDIA-BioNeMo:main Sep 22, 2026
16 checks passed
@scal444
scal444 deleted the codex/ruff-followup branch September 23, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants