ci: AUT-1408 replace cicd PAT with GitHub App tokens - #280
Open
svcnemo-autobot wants to merge 1 commit into
Open
ci: AUT-1408 replace cicd PAT with GitHub App tokens#280svcnemo-autobot wants to merge 1 commit into
svcnemo-autobot wants to merge 1 commit into
Conversation
Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
Contributor
Greptile SummaryReplaces the long-lived PAT used to publish skipped-coverage statuses with a short-lived GitHub App installation token.
Confidence Score: 5/5The PR appears safe to merge, with the generated token targeting the same repository and commit-status operation as the credential it replaces. The workflow preserves the existing status publication call and introduces the token-generation step before its only consumer; no concrete reachable failure or repository-rule violation was identified. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
BotId[vars.BOT_ID] --> Mint[Create GitHub App token]
BotKey[secrets.BOT_KEY] --> Mint
Mint --> Script[GitHub Script]
Script --> Status[Publish codecov/patch status]
Reviews (1): Last reviewed commit: "ci: AUT-1408 replace cicd PAT with GitHu..." | Re-trigger Greptile |
|
/ok to test 262c762 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
cicd-mainused the long-livedsecrets.PATcredential to publish fake coverage statuses.What changed
Mint a short-lived GitHub App token from
vars.BOT_IDandsecrets.BOT_KEY, then pass it toactions/github-script.Details
The token action is pinned to immutable v3.2.0.
Tested
pre-commit run --all-files --show-diff-on-failure --color=neversecrets.PATreferencesgit diff --check