Introduce new shampoo and soap - #281
Open
skyw wants to merge 9 commits into
Open
Conversation
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
skyw
force-pushed
the
skyw/introduce_new_shampoo_and_soap
branch
from
August 7, 2026 23:25
f050252 to
a9b2fcf
Compare
Contributor
Author
|
@greptileai review the draft |
Contributor
Author
|
/ok to test a9b2fcf |
Contributor
Greptile SummaryThe PR moves the experimental SOAP implementation into a dedicated Shampoo package and introduces reusable preconditioner protocols and a ReKLS variant.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
Loop["SoapBase.step"] --> Protocol["SoapPreconditionerProtocol"]
Protocol --> KL["KlSoapPreconditioner"]
Protocol --> ReKLS["ReklsPreconditioner"]
KL --> QR["Orthogonal iteration"]
ReKLS --> Eigh["Full eigendecomposition"]
KL --> Scalar["Adam / MAdam scalar update"]
ReKLS --> Scalar
Scalar --> Param["Parameter update"]
Reviews (5): Last reviewed commit: "add more tests" | Re-trigger Greptile |
Contributor
Author
|
/ok to test a9b2fcf |
Test Results 91 files + 2 169 suites +8 1m 57s ⏱️ +5s For more details on these failures, see this check. Results for commit 4f516ff. ± Comparison against base commit 170d1b8. ♻️ This comment has been updated with latest results. |
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
skyw
marked this pull request as ready for review
August 8, 2026 03:23
Signed-off-by: Hao Wu <skyw@nvidia.com>
Contributor
Author
|
/ok to test 715ce11 |
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
Contributor
Author
|
/ok to test 4f516ff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve abstraction. clear path for more variant of Shampoo and Soap.