feat(agents): add aggregate metrics proxy helper - #2437
Open
Atharva-Kanherkar wants to merge 4 commits into
Open
feat(agents): add aggregate metrics proxy helper#2437Atharva-Kanherkar wants to merge 4 commits into
Atharva-Kanherkar wants to merge 4 commits into
Conversation
Checkpoint: add the shared bounded proxy and focused tests. Reviewed against the temporary test contract. Signed-off-by: Atharva-Kanherkar <142440039+Atharva-Kanherkar@users.noreply.github.com>
Checkpoint: migrate every current resource proxy adopter. Reviewed against the temporary test contract. Signed-off-by: Atharva-Kanherkar <142440039+Atharva-Kanherkar@users.noreply.github.com>
Signed-off-by: Atharva-Kanherkar <142440039+Atharva-Kanherkar@users.noreply.github.com>
Replace the inline 600.0 default on proxy_aggregate_metrics with DEFAULT_AGGREGATE_METRICS_PROXY_TIMEOUT_SECS and pin the default in a unit test, so the bound cannot silently regress to unbounded. Signed-off-by: Atharva-Kanherkar <142440039+Atharva-Kanherkar@users.noreply.github.com>
nemo-automation-bot
Bot
added
the
community-request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2250
adds the shared proxy helper and migrates current adopters.
tests: full core suite, changed agent suites, pre-commit