Use explicit volume mount definition for kubeflow workdir#501
Open
nathan-az wants to merge 6 commits intoNVIDIA-NeMo:mainfrom
Open
Use explicit volume mount definition for kubeflow workdir#501nathan-az wants to merge 6 commits intoNVIDIA-NeMo:mainfrom
nathan-az wants to merge 6 commits intoNVIDIA-NeMo:mainfrom
Conversation
Author
|
@ko3n1g it looks like the kuberay executor just uses the first entry in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The motivation behind this PR was to better support
subPathand other volume mount options for the workdir. Due to a cloud limitation, our users share a PVC, and subPaths provide level of virtual isolation. So the main change is – users specify the dict for the mount itself rather than name and path. The rest of the logic is the same (including appending toexecutor.volume_mountsif the user didn't explicitly include it there).The pattern here changes to users explicitly specifying the
VolumeMountthey want for the workdir, expecting thatvolumescontains the relevant volume. e.g.I haven't tested this yet on a real cluster, but will do so next week. PR is to get thoughts on the change in pattern. I haven't yet used the
kuberayexecutor but will do the same soon, so if there is an analogous change will be able to do so there.@ko3n1g let me know if you have any thoughts on the pattern, or issues with the PR.