Repository navigation
examples/egocap: add Ego Capture UI example - #1403
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Gareth Morgan <gmorgan@nvidia.com>
Contributor
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
 |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 64.13% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documenta… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly summarizes the main change: adding the Ego Capture UI example and its supporting components. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 64.13% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 460 functions across 50 files. (155 skipped: 30 unsupported, 125 over the file limit.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Finishing Touches
-
Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
gareth-morgan-nv
requested review from
AndreusNvidius,
jiwenc-nv and
qingsi-at-nv
October 30, 2026 16:05
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Gareth Morgan <gmorgan@nvidia.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Gareth Morgan <gmorgan@nvidia.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Gareth Morgan <gmorgan@nvidia.com>
jiwenc-nv
approved these changes
Oct 30, 2026
jiwenc-nv
left a comment
jiwenc-nv
left a comment
Collaborator
There was a problem hiding this comment.
1/ do we really need those pico glb files in the code base? can we populate them from http?
At least put them into git lfs: currently glb is not registered for git lfs: https://github.com/NVIDIA/IsaacCapture/blob/main/.gitattributes
please fix.
2/ we can refactor in a next PR: it's a bit weird that frontend and recordings_backend are splatted.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Gareth Morgan <gmorgan@nvidia.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Gareth Morgan <gmorgan@nvidia.com>
CaptureServer's websocket is a native-client-only endpoint (CaptureClient, replay tools); the web backend proxies browser access through its own same-origin /api/session instead. Setting origins=[None] rejects any handshake carrying an Origin header while still accepting the missing-Origin native clients this server actually serves. Verified with real handshakes: no-Origin clients connect; a hostile Origin and a literal "null" Origin are both rejected with HTTP 403. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Gareth Morgan <gmorgan@nvidia.com>
gareth-morgan-nv
force-pushed
the
gmorgan/egocap-transfer
branch
from
October 31, 2026 00:01
02a9781 to
2f1e826
Compare
Contributor
Author
|
🤖 Agent-generated (Claude Code · claude-sonnet-5-5) Re: @jiwenc-nv's review comments. 1/ GLB files not in git-lfs -- fixed. Confirmed: On "do we really need these in the codebase / can we populate from HTTP instead" -- leaving that as-is for now since it's a design question about this example's asset-provisioning approach, not a mechanical fix; happy to follow up if you want to pursue a fetch-at-build-time approach instead. 2/ frontend/recordings_frontend layout -- noted, no action taken. You already scoped this to a follow-up PR ("we can refactor in a next PR"), so leaving it out of this one as you suggested. |
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Gareth Morgan <gmorgan@nvidia.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Gareth Morgan <gmorgan@nvidia.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Gareth Morgan <gmorgan@nvidia.com>
gareth-morgan-nv
enabled auto-merge (squash)
October 31, 2026 00:11
Nothing reads the module-level alias of protocol.HAND_JOINT_NAMES. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Gareth Morgan <gmorgan@nvidia.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Imports the Ego Capture UI example: a recording module library, a standalone CaptureServer, and a web backend/frontend for ego-centric capture sessions. The source layout and behavior are preserved from the upstream example; destination-required formatting, file-mode, and license-header fixes were applied on top.
Notes for reviewers
examples/egocap/recording/tools/replay_episode.pymade executable (shebang-executable check),NOTICE.md/config.yamltrailing-whitespace/EOF fixes, and standard SPDX headers added across the tree (third-partyLICENSE.*/NOTICE.mdprovenance text itself was left untouched).Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
🤖 Generated with Claude Code
Summary by CodeRabbit