Skip to content

state vcpkg toolchain needs a fresh build - #898

Merged
shaosu-nvidia merged 1 commit into
mainfrom
ssx/oak_configure
Aug 6, 2026
Merged

state vcpkg toolchain needs a fresh build#898
shaosu-nvidia merged 1 commit into
mainfrom
ssx/oak_configure

Conversation

@shaosu-nvidia

@shaosu-nvidia shaosu-nvidia commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Description

Update doc to state that oak needs vcpkg toolchain configured on a fresh build so need to delete the existing one.
Fixes #893

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Testing

N/A

Checklist

  • I have read and understood the contribution guidelines
  • I have run the linter and formatter with SKIP=check-copyright-year pre-commit run --all-files
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix/feature works (or explained why not) not applicable
  • I have signed off all my commits (git commit -s) per the DCO

Summary by CodeRabbit

  • Documentation
    • Updated OAK camera build instructions to clarify that toolchain settings apply only during initial configuration.
    • Added guidance to remove the existing build directory before running CMake.

@shaosu-nvidia shaosu-nvidia self-assigned this Aug 4, 2026
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 95ff7976-72b8-4e45-b781-75f3d140d07e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The OAK camera build instructions now state that CMAKE_TOOLCHAIN_FILE applies only during initial CMake configuration. The instructions remove the existing build/ directory before running CMake. This prevents reuse of a build tree configured without the vcpkg toolchain.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the documentation change requiring a fresh build for the vcpkg toolchain.
Linked Issues check ✅ Passed The documentation requires deleting the existing build directory before configuring the OAK plugin with the vcpkg toolchain, satisfying issue #893.
Out of Scope Changes check ✅ Passed The changes are limited to OAK build documentation and directly address issue #893.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ssx/oak_configure

Comment @coderabbitai help to get the list of available commands.

@shaosu-nvidia
shaosu-nvidia requested a review from jiwenc-nv August 4, 2026 19:10
Signed-off-by: Shao Su <shaoxiangs@nvidia.com>
@shaosu-nvidia
shaosu-nvidia merged commit 1a324ab into main Aug 6, 2026
42 checks passed
@shaosu-nvidia
shaosu-nvidia deleted the ssx/oak_configure branch August 6, 2026 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OAK plugin build fails when build/ was already configured without the vcpkg toolchain

2 participants