-
Notifications
You must be signed in to change notification settings - Fork 56
docs: document OpenTelemetry metadata promotion #803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ericevans-nv
wants to merge
9
commits into
NVIDIA:main
Choose a base branch
from
ericevans-nv:docs/otel-metadata-promotion
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e7292ab
docs(observability): document metadata promotion
ericevans-nv 2901e8e
docs(observability): clarify literal metadata prefixes
ericevans-nv 136c5bb
docs(observability): align metadata promotion contract
ericevans-nv 2fafe0f
docs(observability): clarify metadata promotion
ericevans-nv 52e197b
Merge remote-tracking branch 'upstream/main' into docs/otel-metadata-…
ericevans-nv 1d6e2c5
Merge remote-tracking branch 'upstream/main' into docs/otel-metadata-…
ericevans-nv 6e8a6db
docs(observability): clarify promotion constraints
ericevans-nv b9fd3f9
Merge branch 'main' into docs/otel-metadata-promotion
ericevans-nv 68c189b
Merge branch 'main' into docs/otel-metadata-promotion
ericevans-nv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Document the emitted attribute names and value encoding.
The section explains which metadata keys are selected, but it does not explain how Relay names or encodes the resulting attributes. State the projected namespace, such as
nemo_relay.start.metadata.tenant, and state that arrays remain JSON strings at their top-level OTLP attribute. Cover the Scope-start, Scope-end, and Mark projections where their namespaces differ.Based on learnings: scalar top-level
data/metadatafields use typed dotted OTLP attributes, and nested arrays remain JSON strings at their top-level OTLP attribute.🤖 Prompt for AI Agents
Source: Learnings