Open
Conversation
|
Label |
drew
force-pushed
the
enforce-lint-checks
branch
from
8891f41 to
5945d08
Compare
pimlock
previously approved these changes
Apr 29, 2026
drew
force-pushed
the
enforce-lint-checks
branch
from
5945d08 to
3223cf9
Compare
Promote cargo clippy from warning-only to error-on-warning across the workspace and the e2e crate. Resolves all existing clippy lints surfaced by the workspace pedantic/nursery config so CI can gate on a clean lint run. Most fixes are mechanical (inline format args, collapse if-let chains, Option::map_or_else, From::from for lossless casts, doc backticks, let-else, raw string hash trimming). A small number of narrow, function-scoped #[allow(...)] attributes were added with comments where clippy's suggestion would change a public/trait signature, FFI/unsafe contracts, or a serde-deserialized protocol shape; no new entries were added to the workspace-level allow list in Cargo.toml.
CI uses rustc 1.95 which catches lints not present in 1.93. Apply suggested fixes: - map(...).unwrap_or(false) -> is_ok_and(...) - map(f).unwrap_or(default) -> map_or(default, f) - Drop unnecessary trailing commas in macro args - Replace manual is_some_and pattern with .is_ok_and(...) - Replace sort_by(|a,b| a.cmp(b)) with sort_by_key - Add module-level allow(result_large_err) on driver gRPC handlers that stream tonic::Status, mirroring openshell-server's grpc/* files.
drew
force-pushed
the
enforce-lint-checks
branch
from
3223cf9 to
1465762
Compare
pimlock
previously approved these changes
Apr 29, 2026
PR #1028 (preserve directory basename for filtered uploads) changed the on-disk layout so that filtered directory uploads land under `<dest>/<basename>/...` rather than `<dest>/...`, matching the unfiltered upload semantics. The accompanying e2e test was not updated and now fails because it still expects `tracked.txt` directly under the download root. Update the assertions to look under the preserved `repo/` basename.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promote
cargo clippyfrom warning-only to error-on-warning across the workspace and thee2e/rustcrate so CI can gate on a clean lint run. Resolves every existing lint surfaced by the workspaceall/pedantic/nurseryconfig.Related Issue
None — direct branch.
Changes
tasks/rust.toml:rust:lintnow runscargo clippy --workspace --all-targets -- -D warningsand additionally lintse2e/rust/Cargo.toml.-D warningsis in effect. Most fixes are mechanical:{var})if let/ifinto let-chains (&&)Option::map_or_else/is_some_and/is_none_orrewritesFrom::fromfor lossless casts;cast_signed/cast_unsigned/try_fromfor narrowing castslet ... else { return }in place ofmatchreturnsr"..."instead ofr#"..."#for raw strings without embedded quotespub(crate)→pubinside private modules where redundant[(...)].into_iter()→std::iter::once(...)#[allow(...)]attributes were added with justification comments where the suggested fix would change a public/trait signature, an FFI/unsafe contract, a serde wire shape, or atonic::Statusreturn shape. No new entries were added to the workspace-level allow list inCargo.toml.Testing
mise run lintpasses (workspace + e2e clippy with-D warnings, format check, license headers, markdown lint, etc.)mise run rust:checkpassescargo test --workspace --no-fail-fast— all unit/integration tests pass exceptsandbox_create_keeps_sandbox_with_forwarding, which fails onmainas well due to a local Docker process holding port 8080 (environmental, unrelated to this PR).Checklist