chore(ci): drop push-to-main trigger from shadow-docker-build#1019
Open
chore(ci): drop push-to-main trigger from shadow-docker-build#1019
Conversation
Per pimlock's review on #973: shadow workflows shouldn't auto-run on main pushes while we're still collecting Phase 3 data, so failures don't clutter the CI run history. Switch to `workflow_dispatch` only — we keep manual dispatch for measurement runs and lose the auto-baseline-on-merge (already had 7 green data points; the pattern was redundant). Refs OS-127. Signed-off-by: Jonas Toelke <jtoelke@nvidia.com>
pimlock
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per pimlock's review on #973: shadow workflows shouldn't auto-run on main pushes while we're still collecting Phase 3 data, so non-blocking failures don't clutter the CI run history. Switching
shadow-docker-build.ymltoworkflow_dispatchonly — same change applied toshadow-rust-native-build.ymldirectly on #973.We keep manual dispatch for measurement runs. The auto-baseline-on-merge pattern was redundant once we had a stable cluster (7 green Phase 3 runs already in OS-127, range 6m32s–7m6s).
Related Issue
shadow-rust-native-build.yml.Changes
.github/workflows/shadow-docker-build.yml: droppush: branches: [main]; keepworkflow_dispatch.Testing
workflow_dispatchruns.shadow-shared-cpu-spike.yml(Phase 2).Checklist