Repository navigation
fix(network): restore Windows binary path normalization - #5014
Open
shailendra-nv wants to merge 1 commit into
Open
shailendra-nv wants to merge 1 commit into
shailendra-nv wants to merge 1 commit into
Conversation
Signed-off-by: shailendras <shailendras@nvidia.com> (cherry picked from commit 8188a931bba467ea9f666cd4a95248efd22458d9) Signed-off-by: shailendras <shailendras@nvidia.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🌿 Preview your docs: https://nvidia-preview-pr-5014.docs.buildwithfern.com/openshell |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore Windows executable-path matching from #3482 on the
windowsbranch, where that behavior is currently missing. A policy namingC:\WINDOWS\SYSTEM32\CURL.EXEnow authorizes trusted runtimec:/windows/system32/curl.exewhen Windows confirms case-insensitive lookup, including subsequent HTTP request checks.This PR intentionally targets
windows. The downstream Windows repository port will follow the merged upstream change.Related Issue
Closes #5013
Changes
openshell-binary-identity, preserving the network crate's prohibition on unsafe code. Never open policy-authored paths or alter the executable path used for hashing.Testing
The current
windowsbase (5d1bfbf9) has exactly the same source tree as the previously tested base. After carrying over the patch, this PR's complete tree is also identical to the tested implementation (8475b9b57a63f946970c048b1bb8584840042dee). Every changed runtime/test file was additionally compared against the source archive used on the Windows machine. Validation below was performed on that identical implementation in this work session; no runtime changes were made while retargeting the PR.dead-code,unused-imports, andclippy::unused-asyncallowances.mise run pre-commitpassed, including the commit hook; policy skill Markdown validation passed.pc_proxy_scopes_network_policy_to_socket_ownercovered exact-path allow, mixed-case/slash allow, and wrong-owner deny (1 passed, 0 failed, 0 ignored). It used the freshly rebuilt supervisor with existing gateway, CLI, and Windows boundary binaries whose runtime code matches this base.git diff --checkpassed after carrying the patch ontowindows.Full
mise run ciwas attempted and stopped on five unchanged VM-driver tests because the macOS host lacksmke2fs/mkfs.ext4(e2fsprogs). The affected network suite passed separately.Checklist