Repository navigation
fix(ci): keep Release Dev publishing when the snap upload or a Go tag breaks it - #5018
Merged
Merged
Conversation
… breaks it Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
matthewgrossman
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
October 28, 2026 22:10
TaylorMutch
approved these changes
Oct 28, 2026
3 tasks
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release Dev has not published since Oct 21. This fixes the two causes on our side: a Go SDK tag breaks version computation, and a failed Snap Store upload holds back the whole dev publication.
Related Issue
Build fix; no separate issue (CONTRIBUTING.md exception for authors with write access).
Failures:
Compute VersionswithValueError: Can't parse version from tag 'sdk/go/v0.1.6'. The stable release tagssdk/go/vX.Y.Zon the release commit,git describepicks it, andsetuptools-scmcannot parse it. This recurs after every stable release until the next-pre.1exists.Publish snapbecause of a store-side review block.release-devneedspublish-snap, so thedevtag and release, GHCR:dev, Helm0.0.0-dev, the dev wheel, and dev docs have all been frozen at229382e51.Changes
pyproject.toml: limitsetuptools-scmtov[0-9]*tags.release-dev.yml:release-devneedsbuild-snapinstead ofpublish-snap. The snap files are still attached to the dev release; a failed Store upload still shows as a failed job but no longer blocks the rest of the dev publication.Why
release-devwaited on the upload: before #4198,build-snapboth built and uploaded tolatest/edge, so needing it implied waiting for the upload. #4198 split the job and kept that ordering on purpose to avoid changing behavior during the refactor, not because anything needs it.What reads the snap, and the effect of this change:
install.shwith thedevversion andOPENSHELL_INSTALL_METHOD=snapinstalls fromlatest/edgein the Store, not from the GitHub Release. No change.latest/edgebut only runs when the whole Release Dev run succeeds. A failed upload still fails the run, so the canary still skips it..snapfiles are still attached to thedevGitHub Release, downloaded from thebuild-snapartifacts.Tradeoff: while the Store rejects uploads, the
devrelease andlatest/edgecan point to different commits.Testing
ac7f615(v0.1.6),git describe --tags --longreturnssdk/go/v0.1.6-0-…; with--match 'v[0-9]*'it returnsv0.1.6-0-….maincheckout without av0.1.7-pre.1tag,uv run python tasks/scripts/release.py get-version --dev --pythonfailed before this change and returned0.1.7.dev15+g6188420e9with it.release.pycomputes release and dev versions with its own tag logic, and wheel builds setSETUPTOOLS_SCM_PRETEND_VERSION_FOR_OPENSHELL, so the tag filter only affects local and editable installs.actionlintpasses;zizmor --offlinefindings unchanged frommain.Checklist