Repository navigation
test(windows): backport server test repairs from #4862 - #5077
Merged
shailendra-nv merged 1 commit intoOct 30, 2026
Merged
Conversation
Reduce the SQLite concurrency fixture to five iterations per writer on Windows so slow fsync does not exhaust the busy timeout. Hold mutation stress-test locks until a wall-clock deadline rather than depending on Windows timer granularity. Retain Windows' existing portable supervisor fixtures. The isolation validation modules changed by #4862 are not present on this branch. Native Windows ARM64 validation: 6630 tests passed, 41 skipped, 0 failed. Backported from commit 92434dc. Signed-off-by: Shailendra Singh <shailendras@nvidia.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
shailendra-nv
enabled auto-merge (squash)
October 30, 2026 20:49
shailendra-nv
deleted the
test/4861-windows-suite-backport/shailendra-nv
branch
October 30, 2026 20:56
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport the two missing server-test fixes from #4862 to
windows. Windows CI currently fails the SQLite concurrent-write fixture withdatabase is locked; the upstream repair reduces Windows-only write iterations and avoids Windows timer rounding in the mutation-lock stress test.Related Issue
Refs #4861 and #4862. This is a localized backport of already-reviewed test repairs; no new issue is required.
Changes
Testing
mise run pre-commitpassed.mise run --skip-tools windows:test:arm64mise run ci)uv run --no-project --with pytest pytest -o "python_files=*_test.py" deploy/sbom/mise run ci)uv run --no-project --with pytest pytest tasks/scripts/codex_security_release_range_test.pymise run ci)uv run --no-project --with pytest pytest tasks/scripts/codex_security_diagnostics_test.pyThe 41 skips are the existing Nextest skips, including ignored runtime tests. Package exclusions and cfg-hidden tests are outside those totals. x64 was not run on this ARM64 host.
Pre-commit used the already-installed x64 Python 3.14.5 and the exact pinned Biome 2.5.4 x64 executable to work around native ARM64 tool failures; repository dependencies are unchanged. Rust checks and tests ran natively on ARM64.
Repository-wide
mise run cistopped in the unchangedtest_missing_invalid_and_symlinked_reports_do_not_echo_contents:Path.symlink_to()raisedWinError 1314because this Windows session lacks the symlink-creation privilege. The diagnostics suite also skipped three platform-specific checks. Later CI tasks did not run; no full-repository CI pass is claimed. The affected native Rust workspace suite and pre-commit both passed.Checklist