fix(provider): align OpenAI fallback model configuration - #325
Open
jstar0 wants to merge 1 commit into
Open
Conversation
Signed-off-by: King Star <mcxin.y@gmail.com>
rng1995
approved these changes
Jul 31, 2026
rng1995
left a comment
Collaborator
There was a problem hiding this comment.
[Automated SkillSpector Review]
Approved. The generated graph model map now follows the same provider-routing decision as chat-model construction, so an OpenAI credential fallback receives OpenAI model defaults instead of the unconfigured metadata provider's IDs. Explicit bindings, configured/keyed providers, CLI providers, Bedrock native auth, slot overrides, and static-only fallback behavior remain intact. The focused constants, provider, build-context, and MCP tests pass (86 tests).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When an unbound API-key provider has no credentials, SkillSpector can construct
an OpenAI fallback client while the graph still assigns model IDs from the
active metadata provider. Analyzers pass those IDs explicitly, so OpenAI-only
semantic scans can send
deepseek-ai/deepseek-v4-flashtoChatOpenAIinsteadof using the OpenAI default.
Fixes #324.
Changes
chat-model routing.
credentials and the OpenAI fallback is configured.
scoped provider bindings, Bedrock native authentication, and no-credential
static-scan defaults.
graph context, and MCP scan boundaries.
Risk
The change is limited to generated model defaults. It does not change explicit
model overrides, provider client construction, analyzer interfaces, scan state,
or CLI/MCP response shapes. Bedrock remains on its existing native-auth model
configuration rather than introducing an AWS credential probe during graph
context construction.
Verification