Add ViT attention plugin FMHA cubins and packed cu_seqlens support#82
Open
micwill755 wants to merge 4 commits into
Open
Add ViT attention plugin FMHA cubins and packed cu_seqlens support#82micwill755 wants to merge 4 commits into
micwill755 wants to merge 4 commits into
Conversation
…as trt::ViTAttentionPlugin custom nodes instead of plain ONNX attention subgraphs
…into TensorRT-Edge-LLM under vitAttentionKernels
Collaborator
|
packed cu_seqlens attention regions - I think this is something we already supported. @nvamberl can you review and confirm if this MR adds additional features for Edge-LLM? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds generated ViT FMHA cubins from TensorRT-LLM into TensorRT-Edge-LLM under vitAttentionKernels and wires them into ViTAttentionPlugin. The plugin now supports both dense additive masks and packed cu_seqlens attention regions, enabling Qwen-style windowed ViT attention without requiring dense [S, S] masks.
Changes
Testing