-
Notifications
You must be signed in to change notification settings - Fork 2.7k
[TRTLLM-13579][feat] BREAKING: Support BCG in Prefill #16609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GuanhuaWang2001
wants to merge
24
commits into
NVIDIA:main
Choose a base branch
from
GuanhuaWang2001:feature/bcg
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
dbfebe8
BCG V1
GuanhuaWang2001 93eb4ce
bcg v2, support more model, fix adp bug and dsv4 bug
GuanhuaWang2001 e2bc3a5
[07/23/14:03] share BCG pool across segments
GuanhuaWang2001 0a98366
[07/23/16:37] benchmark DSV4 1P1D AAAgent with BCG
GuanhuaWang2001 c846c64
[07/24/20:09] refactor DSv4 BCG epilogue fusion
GuanhuaWang2001 d7ad556
fix bcg and epilogue
GuanhuaWang2001 bccfed8
rename some var name to make mla more clear
GuanhuaWang2001 d9e373d
[None][test] add focused BCG accuracy coverage
GuanhuaWang2001 24830d8
[None][chore] apply pre-commit fixes to BCG changes
GuanhuaWang2001 acc3ef2
[None][fix] preserve PCG behavior with breakable CUDA graphs
GuanhuaWang2001 9fa7403
[None][test] remove DeepSeek V4 BCG accuracy tests
GuanhuaWang2001 7650e7b
[None][fix] repair BCG tests after rebase
GuanhuaWang2001 003a913
[None][fix] avoid implicit legacy PCG bucket conflicts
GuanhuaWang2001 85f10f7
[None][fix] restrict eager graph captured values
GuanhuaWang2001 23318fb
reorganize tests
GuanhuaWang2001 2eaa266
[None][test] provide valid prepared graph inputs
GuanhuaWang2001 f4cc607
[None][fix] keep prefill warmup ranks aligned
GuanhuaWang2001 eaafc4e
[None][fix] simplify breakable CUDA graph helpers
GuanhuaWang2001 d1a650d
chore: apply post-rebase formatting
GuanhuaWang2001 187964c
[None][fix] address breakable CUDA graph review feedback
GuanhuaWang2001 a656945
[None][fix] update prefill graph flag after rebase
GuanhuaWang2001 efa156a
[None][fix] repair breakable graph CI regressions
GuanhuaWang2001 39b3924
Merge branch 'main' into feature/bcg
GuanhuaWang2001 4bf70af
[None][fix] retain eager bridge output storage
GuanhuaWang2001 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This paragraph is hard to parse ("on one GPU for context-only, tensor/pipeline parallelism and mixed context/decode batches" reads as contradictory) and overstates the guardrails: the codebase has no init-time rejection or per-request eager fallback for speculative decoding, LoRA, or multimodal under the breakable backend. It also says "BF16 Qwen3.5 on one GPU" while this PR's own integration tests exercise NVFP4 and multi-GPU TP/PP.
Please rewrite to state exactly what is supported and what happens (error vs. fallback vs. undefined) for each unsupported feature, matching the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rewrote the paragraph to clearly separate tested coverage from restrictions and to match the code: speculative decoding is supported, LoRA/multimodal are rejected, and context logits run eagerly.