Skip to content

[https://nvbugs/6478707][fix] detect v2 inside remove_functionalize_inner, resolve each mutates_args via… #16629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trtllm-agent wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

[https://nvbugs/6478707][fix] detect v2 inside remove_functionalize_inner, resolve each mutates_args via… #16629

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tensorrt_llm/_torch/compilation/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,9 @@ def inplace_info():
2: "output_sf"
},
"mla_custom_op_inplace": {
1: "output"
1: "output",
2: "dsv4_output",

@brnguyen2 brnguyen2 Aug 9, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a case to tests/unittest/_torch/compilation/test_remove_copy_pass.py covering the DSv4-enabled graph — _all_bases=(output, dsv4_output, dsv4_output_sf) with all three _<arg>_base_index set and getitem users at 1/2/3. The existing tests only exercise the all-None variant, so index 2/3 here are untested; under auto_functionalized_v2 the getitem index is a position in _all_bases, not in the declared arg list, and a wrong entry silently rewires a getitem to the wrong buffer rather than failing loudly.

3: "dsv4_output_sf",
},
"mla_dsa_attn_inplace": {
1: "output"
Expand Down
Loading