[https://nvbugs/6445316][fix] Renamed the worker's forward method to _forward_impl (matching every sibling… - #16731
Conversation
Signed-off-by: Chenfei Zhang <chenfeiz@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughRenames ChangesDynamic tree worker entrypoint
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
This is already on #16730 (nvbugs/6478715) and #16731 (nvbugs/6445316) are byte-identical to each other and to what merged, so both are no-ops. Suggest closing both and resolving the two bugs as duplicates of 6442074. |
Summary
Test plan
Links
Dev Engineer Review
MTPEagleDynamicTreeWorker.forwardto_forward_implwithout changing its signature, implementation, or NVTX decorator.TypeErrorenforced bySpecWorkerBase.__init_subclass__.QA Engineer Review