Skip to content

[https://nvbugs/6465993][fix] unwaive mamba tests - #16941

Merged
bo-nv merged 1 commit into
NVIDIA:mainfrom
bo-nv:main-unwaive
Jul 29, 2026
Merged

[https://nvbugs/6465993][fix] unwaive mamba tests#16941
bo-nv merged 1 commit into
NVIDIA:mainfrom
bo-nv:main-unwaive

Conversation

@bo-nv

@bo-nv bo-nv commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Dev Engineer Review

  • Updated TestNemotron3Super120B.test_auto_dtype to use explicit parameter combinations, aligning IDs and argument order while preserving skip and MTP logic.
  • Removed the two corresponding SKIP waiver entries from waives.txt; paths and formatting are consistent.
  • No apparent regressions or unintended scope changes.

QA Engineer Review

  • Modified test: TestNemotron3Super120B.test_auto_dtype.
  • The test is represented in tests/integration/test_lists/waives.txt; no test-db/ or qa/ coverage changes were provided.
  • Verdict: needs follow-up because CBTS coverage data is unavailable.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Bo Deng <deemod@nvidia.com>
@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 95c9c61c-e9f9-40e9-840d-ee9540d1f2b6

📥 Commits

Reviewing files that changed from the base of the PR and between 2a7231d and 4459761.

📒 Files selected for processing (2)
  • tests/integration/defs/accuracy/test_disaggregated_serving.py
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

Walkthrough

The PR replaces independent test parametrization decorators with explicit parameter combinations and removes two integration-test waiver entries.

Changes

Integration test matrix updates

Layer / File(s) Summary
Explicit test combinations and waiver removal
tests/integration/defs/accuracy/test_disaggregated_serving.py, tests/integration/test_lists/waives.txt
The Nemotron test defines explicit (mtp_nextn, block_reuse, use_py_transceiver) combinations with matching IDs and signature order; two related SKIP waivers are deleted.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: stanleysun639

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title mentions unwaiving mamba tests, but the PR actually removes waivers for disaggregated serving integration tests. Rename it to match the actual change, e.g. unwaiving the specific disaggregated serving test waivers.
Description check ⚠️ Warning The description is only the repository template; it does not explain the issue, solution, or test coverage. Replace the template text with a short summary of the bug, the waiver removals, and the tests that validate the change.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@bo-nv

bo-nv commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator Author

/bot --help

@github-actions

Copy link
Copy Markdown

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental) --high-priority]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Supports wildcard * for pattern matching (e.g., "*PerfSanity*" matches all stages containing PerfSanity). Examples: "A10-PyTorch-1, xxx", "PerfSanity". The patterns "*", "*Post-Merge*", and "*PerfSanity*", including equivalent escaped or repeated-star forms and their use in comma-separated lists, require the ci: post-merge approved PR label. Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline. Requires the ci: post-merge approved PR label applied by an active member of NVIDIA/trt-llm-ci-approvers. The approval label remains in place when new commits are pushed.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Supports wildcard * for pattern matching. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx", --extra-stage "Post-Merge". The patterns "*", "*Post-Merge*", and "*PerfSanity*", including equivalent escaped or repeated-star forms and their use in comma-separated lists, require the ci: post-merge approved PR label.

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

--high-priority (OPTIONAL) : Run the pipeline with high priority. This option is restricted to authorized users only and will route the job to a high-priority queue.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@bo-nv

bo-nv commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --add-multi-gpu-test --skip-test --extra-stage "*DGX_B200-8_GPUs-PyTorch*"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #62161 [ run ] triggered by Bot. Commit: 4459761 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #62161 [ run ] completed with state ABORTED. Commit: 4459761

Link to invocation

@fredricz-20070104

Copy link
Copy Markdown
Collaborator

PR Checklist / Test Coverage follow-up

The Check PR Checklist Resolution gate is currently FAILURE because the PR description is using the empty template — the Test Coverage section has not been filled in. CodeRabbit also flagged that QA needs to follow up here.

The code change itself is low-risk (test-list / parametrization cleanup only, no source changes, and the resulting test IDs match the QA lists and test-db), but before merge please:

  1. Fill in the Test Coverage section of the PR description with the test IDs that are being unwaived / re-parametrized, e.g.:
    • accuracy/test_llm_api_pytorch.py::TestNemotron3Super120B::test_auto_dtype[mtp_nextn=0-block_reuse=False-use_py_transceiver=False]
    • accuracy/test_llm_api_pytorch.py::TestNemotron3Super120B::test_auto_dtype[mtp_nextn=0-block_reuse=False-use_py_transceiver=True]
    • accuracy/test_llm_api_pytorch.py::TestNemotron3Super120B::test_auto_dtype[mtp_nextn=3-block_reuse=True-use_py_transceiver=False]
    • the unwaived Qwen3Next case [use_py_transceiver=False]
  2. Confirm the underlying bugs are actually fixed. This is an "unwaive" change — it does not fix anything by itself; it re-enables tests on the assumption the root-cause fixes have already landed. The two removed waivers reference nvbugs/6478726 (Nemotron use_py_transceiver=True) and nvbugs/6427411 (Qwen3Next use_py_transceiver=False), which are different from the title bug nvbugs/6465993. Please make sure blossom-ci runs green on exactly these re-enabled cases before merge — that is the only reliable signal that 6478726 / 6427411 are truly resolved.

Minor (non-blocking) nit: after the reparametrization no combination has both use_py_transceiver=True and block_reuse=True, so the pytest.skip("Python transceiver does not support block reuse") branch in the test is now dead code and could be removed.

@fredricz-20070104 fredricz-20070104 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@bo-nv

bo-nv commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --add-multi-gpu-test --skip-test --extra-stage "DGX_B200-8_GPUs-PyTorch"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #62392 [ run ] triggered by Bot. Commit: 4459761 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #62392 [ run ] completed with state FAILURE. Commit: 4459761
/LLM/main/L0_MergeRequest_PR pipeline #50552 (Partly Tested) completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@bo-nv

bo-nv commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #62418 [ run ] triggered by Bot. Commit: 4459761 Link to invocation

@bo-nv

bo-nv commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --add-multi-gpu-test --skip-test --extra-stage "*DGX_B200-8_GPUs-PyTorch*"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #62432 [ run ] triggered by Bot. Commit: 4459761 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #62418 [ run ] completed with state ABORTED. Commit: 4459761

Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #62432 [ run ] completed with state SUCCESS. Commit: 4459761
/LLM/main/L0_MergeRequest_PR pipeline #50589 (Partly Tested) completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@bo-nv

bo-nv commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@bo-nv

bo-nv commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator Author

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #62485 [ run ] triggered by Bot. Commit: 4459761 Link to invocation

@bo-nv
bo-nv enabled auto-merge (squash) July 29, 2026 09:07
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #62487 [ skip ] triggered by Bot. Commit: 4459761 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #62485 [ run ] completed with state ABORTED. Commit: 4459761

Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #62487 [ skip ] completed with state SUCCESS. Commit: 4459761
Skipping testing for commit 4459761

Link to invocation

@bo-nv
bo-nv merged commit 38389f9 into NVIDIA:main Jul 29, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants