[https://nvbugs/6541322][fix] Remove stale waiver for TestQwen3NextInstruct::test_bf16_4gpu[dep4] - #17150
[https://nvbugs/6541322][fix] Remove stale waiver for TestQwen3NextInstruct::test_bf16_4gpu[dep4]#17150trtllm-agent wants to merge 1 commit into
Conversation
The V2 Mamba state pool ValueError was fixed by 7f7dccf (KVCacheManagerV2 C++ translation, NVIDIA#14047), which added an SSM min-slot floor in _build_cache_config using the same expression as the live/dummy-slot check it guards, so the pool can no longer be sized below that floor. Remove the now-stale waiver for test_bf16_4gpu[dep4]. The sibling test_nvfp4[tp1_block_reuse-cutlass] waiver is left in place: it has an independent root cause tracked separately under nvbugs/6535767. Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughThe change removes the skip entry for Changes
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot run --only-qa-verify test accuracy/test_llm_api_pytorch.py::TestQwen3NextInstruct::test_bf16_4gpu[dep4] |
|
PR_Github #63612 [ run ] triggered by Bot. Commit: |
|
NVBug 6541322 was closed as Bug - Fixed. The repair-bot root cause matches the merged resolution #17131, so this PR is being auto-closed. If you believe this is wrong, reopen the PR — the bot will never auto-close a human-reopened PR for this cleanup generation. |
|
PR_Github #63612 [ run ] completed with state |
Summary
max_num_requests; that floor fix has since landed in HEAD via commit 7f7dccf, so the failing code path no longer exists. The waiver entry for this test therefore outlived the defect it was tracking.nvidia-smi, leaving 53 MB free at a cublas allocation), so no product change was warranted. The change is waiver-only: drop thedep4SKIP line so the test runs again in CI, while leaving the siblingtp1_block_reuse-cutlasswaiver under the same bug in place since it was not shown to be fixed.Test plan
Links
Dev Engineer Review
dep4waiver forTestQwen3NextInstruct::test_bf16_4gpu[dep4].tp1_block_reuse-cutlasswaiver remains unchanged.QA Engineer Review
tests/integration/test_lists/waives.txt.