Skip to content

[https://nvbugs/6388363][test] Unwaive the test of TestDeepSeekV3Lite… - #17398

Merged
WeiHaocheng merged 1 commit into
NVIDIA:mainfrom
WeiHaocheng:fix/nvbug-6388363-unwaive
Aug 9, 2026
Merged

[https://nvbugs/6388363][test] Unwaive the test of TestDeepSeekV3Lite…#17398
WeiHaocheng merged 1 commit into
NVIDIA:mainfrom
WeiHaocheng:fix/nvbug-6388363-unwaive

Conversation

@WeiHaocheng

@WeiHaocheng WeiHaocheng commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

… accuracy issue as can not reproduce

Dev Engineer Review

  • Removed the waiver for TestDeepSeekV3Lite::test_nvfp4 with the CUTLASS backend and mtp_nextn=2.
  • The waiver file change uses the existing test identifier and removes only the targeted entry.
  • No API, performance, or error-handling changes are included.
  • The change is consistent with the objective because the reported accuracy issue was not reproduced.

QA Engineer Review

  • No test-db/ or qa/ files were modified.
  • Removed the TestDeepSeekV3Lite::test_nvfp4 waiver from tests/integration/test_lists/waives.txt.
  • CBTS coverage data is unavailable.
  • Verdict: needs follow-up.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

… accuracy issue as can not reproduce

Signed-off-by: WeiHaocheng <20514172+WeiHaocheng@users.noreply.github.com>
@WeiHaocheng

Copy link
Copy Markdown
Collaborator Author

/bot run

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2e52f966-5e70-4fd0-825f-ba1c38cee554

📥 Commits

Reviewing files that changed from the base of the PR and between 530ad05 and ac22c4e.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

Walkthrough

Removes the skip waiver for TestDeepSeekV3Lite::test_nvfp4 with the CUTLASS backend and mtp_nextn=2.

Changes

Cohort / File(s) Summary
Test waiver removal
tests/integration/test_lists/waives.txt
Removes the obsolete skip waiver for the DeepSeek V3 Lite NVFP4 test configuration.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: brnguyen2

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description gives minimal context but does not explain the solution, list test coverage, or complete the PR checklist. Add a clear issue and solution summary, identify the relevant test coverage, and complete the PR checklist.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title identifies the NVBug, uses a valid type, and clearly states that the TestDeepSeekV3Lite test is being unwaived.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #64488 [ run ] triggered by Bot. Commit: ac22c4e Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #64488 [ run ] completed with state SUCCESS. Commit: ac22c4e
/LLM/main/L0_MergeRequest_PR pipeline #52357 completed with status: 'SUCCESS'

CI Report

Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants