[None][fix] Set in_mtp_draft_loop on the synthetic DSA metadata stub - #17416
Conversation
test_on_update_kv_lens_rebuilds_stale_map builds its metadata with object.__new__, bypassing __init__ where in_mtp_draft_loop is initialized. Since NVIDIA#16925 made on_update_kv_lens() read that flag, the test fails with AttributeError on every pre-merge run. Set the __init__ default on the stub. Signed-off-by: Brian Nguyen <brnguyen@nvidia.com>
|
/bot run |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughThe test fixture now initializes ChangesDSA test fixture
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR_Github #64587 [ run ] triggered by Bot. Commit: |
|
PR_Github #64587 [ run ] completed with state |
Summary
test_on_update_kv_lens_rebuilds_stale_map(added in #16925) builds itsDSAtrtllmAttentionMetadatawithobject.__new__, bypassing__init__— the only placein_mtp_draft_loopis initialized. The same PR madeon_update_kv_lens()read that flag, so the test fails deterministically withon every pre-merge CI run since it merged (seen on H100, B200, and B300 pre-merge stages across unrelated PRs).
Fix
Set the
__init__default (False) on the synthetic stub, matching how the test already stubs its other collaborators.Validation
Full
tests/unittest/_torch/attention/sparse/dsa/test_req_idx_per_token.pyrun on a Blackwell node: 11/11 pass.Dev Engineer Review
md.in_mtp_draft_looptoFalsein the synthetic metadata fixture.AttributeErrorcaused by bypassingDSAtrtllmAttentionMetadata.__init__.QA Engineer Review
test_on_update_kv_lens_rebuilds_stale_map.tests/integration/test_lists/was not provided.