Skip to content

[https://nvbugs/6566772][fix] Predicate idle on not self.is_shutdown so a non-blocking timedelta(0) is… #17426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trtllm-agent wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −2
Open

[https://nvbugs/6566772][fix] Predicate idle on not self.is_shutdown so a non-blocking timedelta(0) is… #17426

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions tensorrt_llm/_torch/pyexecutor/py_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4947,8 +4947,13 @@ def _fetch_and_enqueue_requests(self, waiting_queue: WaitingQueue,
if len(self.control_requests) != 0:
return

# Calculate timeout
idle = (total_num_active_requests == 0) and len(waiting_queue) == 0
# Calculate timeout. Never wait once the shutdown sentinel has been
# consumed: no further item will arrive to wake a blocking get(), so
# blocking would keep the loop from reaching the
# `should_stop_processing` check that ends it, deadlocking shutdown()
# on `shutdown_event`.
idle = (total_num_active_requests == 0 and len(waiting_queue) == 0
and not self.is_shutdown)
if idle:
# In Ray path (TLLM_DISABLE_MPI=1), use a periodic heartbeat timeout so rank 0
# reaches the broadcast path regularly to prevent trtllm-serve timeout when idle.
Expand Down
Loading