[None][infra] Waive 1 failed cases for main in pre-merge 52592 - #17443
Conversation
Bug(s): 6578853 Requested by: @dominicshanshan Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
WalkthroughThe integration waiver list now skips ChangesBenchmark test waiver
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tests/integration/test_lists/waives.txt (1)
1-1: 📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick winUpdate waiver parsing before adding the copyright header.
Add the 2026 NVIDIA SPDX header after
verify_waive_listignores#comment lines. The current verifier treats header lines as nonexistent test names, while the integration parser ignores them. The waiver entry is already listed intest-db/l0_b200.yml.Coverage summary: no test-code changes; no
test-db/orqa/files changed. One waiver entry was added. Coverage verdict: needs follow-up because no CBTS artifact is available.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/integration/test_lists/waives.txt` at line 1, Update verify_waive_list to ignore lines beginning with # when parsing waivers, matching the integration parser’s behavior. Then add the 2026 NVIDIA SPDX copyright header to waives.txt, ensuring it is treated as a comment rather than a test name and preserving the existing waiver entry.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 1: Update verify_waive_list to ignore lines beginning with # when parsing
waivers, matching the integration parser’s behavior. Then add the 2026 NVIDIA
SPDX copyright header to waives.txt, ensuring it is treated as a comment rather
than a test name and preserving the existing waiver entry.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 43bae39c-784b-41da-92ab-703965a2a3ce
📒 Files selected for processing (1)
tests/integration/test_lists/waives.txt
|
/bot skip --comment "waive only" |
|
PR_Github #64831 [ skip ] triggered by Bot. Commit: |
|
PR_Github #64831 [ skip ] completed with state |
Auto-generated Waive PR
Created by: TensorRT LLM CI Report (requested by @dominicshanshan)
Target branch:
mainBug(s): 6578853
Waive entries added
This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.
Dev Engineer Review
unittest/tools/test_layer_wise_benchmarks.py::test_performance_alignment[1].6578853.tests/integration/test_lists/waives.txt.QA Engineer Review
test-db/orqa/files were modified.Verdict: needs follow-up.