Skip to content

[None][test] Unwaive qwen3.5 test cases - #17472

Open
nv-guomingz wants to merge 1 commit into
NVIDIA:mainfrom
nv-guomingz:user/guomingz/unwaive_qwen35_case
Open

[None][test] Unwaive qwen3.5 test cases#17472
nv-guomingz wants to merge 1 commit into
NVIDIA:mainfrom
nv-guomingz:user/guomingz/unwaive_qwen35_case

Conversation

@nv-guomingz

@nv-guomingz nv-guomingz commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Dev Engineer Review

  • Updated tests/integration/test_lists/waives.txt.
  • Removed three Qwen3.5 397B NVFP4 waiver entries:
    • adp4_cutedsl
    • Static EPLB
    • GB200 online EPLB
  • Retained the ADP4 TRTLLM and TEP4 entries.
  • The change has no code, API, performance, or error-handling impact.
  • The waiver list format and scope remain consistent.

QA Engineer Review

  • No test-db/ or qa/ files were modified.
  • Removed the listed Qwen3.5 waiver entries from tests/integration/test_lists/waives.txt.
  • CBTS coverage data is unavailable.
  • Verdict: needs follow-up.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: nv-guomingz <137257613+nv-guomingz@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

The integration waiver list removes obsolete Qwen3.5 397B NVFP4 and GB200 online EPLB skip entries. ADP4 TRTLLM and TEP4 entries remain.

Changes

Integration waiver cleanup

Layer / File(s) Summary
Update Qwen3.5 397B waivers
tests/integration/test_lists/waives.txt
Removes the ADP4 CuteDSL, static EPLB, and GB200 online EPLB skip entries. Retains the ADP4 TRTLLM and TEP4 entries.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: schetlur-nv

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description contains only the template and checklist, with no explanation of the change or test coverage details. Add a brief Description that states why the Qwen3.5 tests are unwaived and list the relevant test coverage or validation performed.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the test change and follows the required [ticket][type] format.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@brnguyen2 brnguyen2 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving — the comments below are optional touch-ups, not blockers.

Two of the three bugs (6418830, 6462928) were never root-caused — they're moving to verify-to-close on "can't reproduce" rather than on a landed fix, so these unwaives are a bet that the flakiness is gone. Please confirm with a targeted CI run before merging: these cases live in post-merge / GB200 / B200 multi-GPU stages that a plain /bot run doesn't cover, so use /bot run --stage-list "DGX_B200-4_GPUs-PyTorch-3, GB200-4_GPUs-PyTorch-2" (adjust to the actual stages) and paste the result. Re-waiving one week later is worse than one extra pipeline now.

Notes on lines outside the diff:

  • tests/integration/test_lists/waives.txt:84: https://nvbugs/6535767 is also the reason for this line (TestNemotronV3Ultra::test_nvfp4_4gpus_static_eplb[moe_backend=CUTLASS]). If that bug is resolved enough to unwaive TestQwen3_5_397B_A17B::test_nvfp4[adp4_cutedsl], this entry is stale too — either remove it in the same PR or re-file it under a distinct bug so the remaining waive has an accurate owner.

@nv-guomingz

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #65180 [ run ] triggered by Bot. Commit: 7372aa4 Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants