Skip to content

[JAX] Fix MNIST L2 jax test instability#2933

Draft
tdophung wants to merge 4 commits intoNVIDIA:mainfrom
tdophung:tdophung/fix-mnist-CI-instability
Draft

[JAX] Fix MNIST L2 jax test instability#2933
tdophung wants to merge 4 commits intoNVIDIA:mainfrom
tdophung:tdophung/fix-mnist-CI-instability

Conversation

@tdophung
Copy link
Copy Markdown
Collaborator

@tdophung tdophung commented Apr 27, 2026

Description

L2 jax unittest for mnist sometimes fails in CI for non-error reasons such as noisy loss near convergence. This PR fixes that with looser thresholds, and checking the min loss in the last 10% of steps to filter out noisy high loss near convergence. Also apply xla flags for deterministic results

Fixes # (issue)

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

  • Loosen loss failure threshold in MNIST test
  • Add xla gpu deterministic flag for this test
  • Fix typo for test accuracy check (9.8% -> 98%)

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

tdophung and others added 3 commits April 27, 2026 10:32
…o avoid failing by noise near convergence

Signed-off-by: tdophung <tdophung@nvidia.com>
Signed-off-by: tdophung <tdophung@nvidia.com>
@tdophung
Copy link
Copy Markdown
Collaborator Author

/te-ci jax L2

@tdophung tdophung changed the title Fix MNIST L2 jax test instability [JAX] Fix MNIST L2 jax test instability Apr 27, 2026
@tdophung
Copy link
Copy Markdown
Collaborator Author

/te-ci jax L2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant