Duplicate radix sort dispatch to deprecate DispatchRadixSort#9530
Duplicate radix sort dispatch to deprecate DispatchRadixSort#9530bernhardmgruber wants to merge 2 commits into
DispatchRadixSort#9530Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
f0a6d7f to
f37a972
Compare
📝 WalkthroughSummary by CodeRabbit
Walkthrough
Radix Sort Dispatch Refactor
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
cub/cub/device/dispatch/dispatch_radix_sort.cuh (1)
1413-1429: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winsuggestion: mark the new non-mutated locals
constwhere applicable, e.g.pass_bits,pass_spine_length,max_grid_size,spine_length,num_bits,is_num_passes_odd,max_alt_passes,alt_end_bit,num_passes,num_portions,max_num_blocks,value_size,histogram_kernel,portion_num_items,num_blocks, andonesweep_kernel. As per coding guidelines, “All variables that are not modified must useconst.”Also applies to: 1588-1623, 1703-1708, 1766-1766, 1851-1858, 1897-1897
Source: Coding guidelines
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 3f483d68-1ebf-4929-8706-48d14f76152a
📒 Files selected for processing (1)
cub/cub/device/dispatch/dispatch_radix_sort.cuh
😬 CI Workflow Results🟥 Finished in 1h 27m: Pass: 99%/287 | Total: 6d 17h | Max: 1h 05m | Hits: 46%/462539See results here. |
cub.bench.radix_sort.pairs.baseon SM75;80;90;100