Skip to content

[Bug] Fix config verification after SOL introduced - #1011

Merged
podkidyshev merged 5 commits into
mainfrom
ipod/sol-verify-conf-fix
Aug 25, 2026
Merged

[Bug] Fix config verification after SOL introduced#1011
podkidyshev merged 5 commits into
mainfrom
ipod/sol-verify-conf-fix

Conversation

@podkidyshev

Copy link
Copy Markdown
Contributor

Summary

verify-configs command uses mocked System object. The recent SOL feature fails on merging scenario case config with system config because mocked objects doesn't have sol property

Test Plan

  • Automated CI

Additional Notes

N/A

@podkidyshev podkidyshev self-assigned this Aug 24, 2026
@podkidyshev podkidyshev added the bug Something isn't working label Aug 24, 2026
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 05394c58-355e-4eef-af52-c7c67e1245c5

📥 Commits

Reviewing files that changed from the base of the PR and between 3369e5d and c1ce5dd.

📒 Files selected for processing (3)
  • .github/workflows/ci.yml
  • src/cloudai/cli/cli.py
  • src/cloudai/cli/handlers.py
💤 Files with no reviewable changes (1)
  • .github/workflows/ci.yml

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.


📝 Walkthrough

Walkthrough

Changes

Configuration verification

Layer / File(s) Summary
Verification reporting and exit status
src/cloudai/cli/handlers.py, src/cloudai/cli/cli.py
Configuration failures now log errors with debug tracebacks. Scenario parsing initializes System with sol={}. The CLI returns status code 1 on failure and 0 on success.
Targeted CI smoke validation
.github/workflows/ci.yml
The smoke test removes the editable reinstall and broad configuration scan. Targeted verification commands remain.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to c1ce5

The PR makes a localized configuration-verification fix, and no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: shreyaskommuri

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the bug fix for configuration verification after introducing SOL.
Description check ✅ Passed The description explains the SOL-related mock configuration failure and identifies automated CI testing.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ipod/sol-verify-conf-fix

Comment @coderabbitai help to get the list of available commands.

Comment thread src/cloudai/cli/cli.py Fixed
@podkidyshev
podkidyshev marked this pull request as ready for review August 24, 2026 14:37

@jj10306 jj10306 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Comment thread .github/workflows/ci.yml
Comment thread .github/workflows/ci.yml

@rutayan-nv rutayan-nv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good catch on the swallowed exit code — that was hiding real failures.

@podkidyshev
podkidyshev merged commit ac9356d into main Aug 25, 2026
6 checks passed
@podkidyshev
podkidyshev deleted the ipod/sol-verify-conf-fix branch August 25, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants