Delete default/move ctor and assignment on hash tables - #835
Open
amarkdotdev wants to merge 1 commit into
Open
Conversation
Owning map/set types were accidentally move-constructible and move-assignable, which can silently transfer GPU storage. Match the copy members and disable default construction too. Fixes NVIDIA#612 Signed-off-by: Aaron <amark@g.jct.ac.il>
sleeepyjack
added
P1: Should have
Collaborator
|
/ok to test 043b2a0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The owning hash table types (
static_map,static_set,static_multimap,static_multiset,dynamic_map) already deleted copy construction and copy assignment, but still defaulted move construction and move assignment. Tests even work around that withunique_ptrbecause a moved table can silently hand off device storage.This deletes the default constructor, move constructor, and move assignment as well, so misuse is a compile error instead of a silent failure.
Fixes #612