fix(ci): avoid pipefail in ci.yaml shell code - #2462
Open
juenglin wants to merge 1 commit into
Open
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: ci failures like this
The CI failure is a classic SIGPIPE +
pipefailinteraction.The original code pipes
gh api --paginateintohead -1. Underbash -o pipefail(set by the shell option in the step), when
head -1reads one line and exits, itcloses the pipe.
gh apithen receives SIGPIPE (exit 141), andpipefailpropagatesthat non-zero exit code through the command substitution, causing the step to fail
under
set -e.The fix avoids this by:
mapfile(no pipe to break).|| trueto suppress any transientgh apiexit code from the process substitution.${_tags[0]:-}instead ofhead -1.