Skip to content

test(cuda.bindings): cover sm_90a, sm_103 and sm_103a in the nvJitLink and nvFatbin tests #3218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0z5a wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(cuda.bindings): cover sm_90a, sm_103 and sm_103a in the nvJitLink and nvFatbin tests #3218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cuda_bindings_13/tests/legacy_api/test_legacy_nvfatbin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

from cuda.bindings import nvfatbin, nvrtc

ARCHITECTURES = ["sm_75", "sm_80", "sm_90", "sm_100"]
ARCHITECTURES = ["sm_75", "sm_80", "sm_90", "sm_90a", "sm_100", "sm_103", "sm_103a"]

@coderabbitai coderabbitai Bot Oct 24, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor · Maintainability & Code Quality · Quick win

important: Do not add new architecture cases to this legacy test list. The tests/legacy_api rule permits updates only when needed to fix test failures. This change adds sm_90a, sm_103, and sm_103a for coverage. Keep these additions in the canonical tests/test_nvfatbin.py list unless a specific legacy failure requires them.

Source: Coding guidelines

PTX_VERSIONS = ["6.4", "7.0", "8.5", "8.8"]

PTX_TEMPLATE = """
Expand Down
4 changes: 2 additions & 2 deletions cuda_bindings_13/tests/legacy_api/test_legacy_nvjitlink.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ def nvjitlink_session(num_options, options):


# Establish a handful of compatible architectures and PTX versions to test with
ARCHITECTURES = ["sm_75", "sm_80", "sm_90", "sm_100"]
PTX_VERSIONS = ["6.4", "7.0", "8.5", "8.8"]
ARCHITECTURES = ["sm_75", "sm_80", "sm_90", "sm_90a", "sm_100", "sm_103", "sm_103a"]
PTX_VERSIONS = ["6.4", "7.0", "8.5", "8.0", "8.8", "8.8", "8.8"]
Comment on lines +23 to +24

@coderabbitai coderabbitai Bot Oct 24, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor · Maintainability & Code Quality · Quick win

important: Keep new architecture coverage out of the legacy suite.

These entries add test coverage; they do not fix a reported legacy test failure. Keep the new cases in cuda_bindings_13/tests/test_nvjitlink.py. Revert the additions here unless they fix a specific failing legacy test. As per coding guidelines: “These test files should not be added to, only updated when necessary to fix test failures.”

Source: Coding guidelines



PTX_HEADER = """\
Expand Down
2 changes: 1 addition & 1 deletion cuda_bindings_13/tests/test_nvfatbin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
from cuda.bindings import nvfatbin
from cuda.bindings._v2 import nvrtc

ARCHITECTURES = ["sm_75", "sm_80", "sm_90", "sm_100"]
ARCHITECTURES = ["sm_75", "sm_80", "sm_90", "sm_90a", "sm_100", "sm_103", "sm_103a"]
PTX_VERSIONS = ["6.4", "7.0", "8.5", "8.8"]

PTX_TEMPLATE = """
Expand Down
4 changes: 2 additions & 2 deletions cuda_bindings_13/tests/test_nvjitlink.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ def nvjitlink_session(num_options, options):


# Establish a handful of compatible architectures and PTX versions to test with
ARCHITECTURES = ["sm_75", "sm_80", "sm_90", "sm_100"]
PTX_VERSIONS = ["6.4", "7.0", "8.5", "8.8"]
ARCHITECTURES = ["sm_75", "sm_80", "sm_90", "sm_90a", "sm_100", "sm_103", "sm_103a"]
PTX_VERSIONS = ["6.4", "7.0", "8.5", "8.0", "8.8", "8.8", "8.8"]


PTX_HEADER = """\
Expand Down
Loading