[Andy-Jost]

Summary

VirtualMemoryIPCBufferDescriptor is the descriptor that carries POSIX file descriptors for VirtualMemoryResource buffers (#3028). A fabric-handle descriptor is about to sit beside it (#2980), and the old name reads as "the" IPC descriptor although both will be. This PR renames it to VirtualMemoryFdBufferDescriptor while 1.3.0 is unreleased. No alias, no behavior change.

Changes

• The cdef class and every reference: _ipc.pyx, _ipc.pxd, _virtual_memory_resource.pyx, the generated .pyi stubs, api_private.rst, the 1.3.0 release-note entry, VMM_DESIGN.md, and tests/memory_ipc/test_vmm_ipc.py.

Related Work

Part of #2980 (fabric handles). Follows #3028.

🤖 Generated with Claude Code

[copy-pr-bot]

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

[Andy-Jost]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: NVIDIA/cuda-python
• Branch: main
• File: .coderabbit.yaml
• Commit: 2e6aa4e
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Enterprise
• Run ID: 937133b2-3ff8-49e3-bd85-8f0a63f4a351

Commits

Reviewing files that changed from the base of the PR and between 2e6aa4e and f128963.

Files selected for processing: 9

• cuda_core/cuda/core/_cpp/rt/VMM_DESIGN.md
• cuda_core/cuda/core/_memory/_ipc.pxd
• cuda_core/cuda/core/_memory/_ipc.pyi
• cuda_core/cuda/core/_memory/_ipc.pyx
• cuda_core/cuda/core/_memory/_virtual_memory_resource.pyi
• cuda_core/cuda/core/_memory/_virtual_memory_resource.pyx
• cuda_core/docs/source/api_private.rst
• cuda_core/docs/source/release/1.3.0-notes.rst
• cuda_core/tests/memory_ipc/test_vmm_ipc.py

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Summary

Summary by CodeRabbit

• Documentation
  • Updated the virtual-memory descriptor name in API documentation and release notes.
• Compatibility
  • Renamed the descriptor used to rebuild virtual-memory buffers from file descriptors. Its behavior remains unchanged.

The VMM IPC descriptor was renamed from VirtualMemoryIPCBufferDescriptor to VirtualMemoryFdBufferDescriptor. Its resource API, type declarations, tests, and documentation now use the new name. The described descriptor behavior and validation remain unchanged.

Changes: VMM descriptor rename

Layer / File(s)	Summary
Descriptor contract and implementation cuda_core/cuda/core/_memory/_ipc.pxd, cuda_core/cuda/core/_memory/_ipc.pyi, cuda_core/cuda/core/_memory/_ipc.pyx	The descriptor declaration and its factory, pickle reconstruction, and buffer-import type check now use VirtualMemoryFdBufferDescriptor.
Resource integration and validation cuda_core/cuda/core/_memory/_virtual_memory_resource.*, cuda_core/tests/memory_ipc/test_vmm_ipc.py, cuda_core/cuda/core/_cpp/rt/VMM_DESIGN.md, cuda_core/docs/source/*	The virtual-memory resource API, tests, design documentation, private API listing, and release notes now use the renamed descriptor.

Possibly related issues

• EPIC: VMM feature completeness #2980: The issue covers VMM IPC support and planned fabric support; this change renames the descriptor used for file-descriptor transfers.
• cuda.core: transfer VMM IPC allocations one at a time #3110: The issue refers to VirtualMemoryIPCBufferDescriptor and a posix_fd-specific design; this change renames that descriptor to VirtualMemoryFdBufferDescriptor.

Possibly related PRs

• NVIDIA/cuda-python#3034: This PR updates the same release-note content, which refers to the descriptor name changed here.

Suggested labels: documentation, test

Suggested reviewers: mdboom, rwgk

Priority: Low

Change: Refactor

Merge Risk: Minimal · up to f1289

The rename is complete across the tracked implementation, bindings, tests, and documentation.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Doc Preview CI
Preview removed because the pull request was closed or merged.