Repository navigation
pathfinder: add cudart_static to the supported static libraries - #3234
Open
srimanachanta wants to merge 1 commit into
Open
srimanachanta wants to merge 1 commit into
srimanachanta wants to merge 1 commit into
Conversation
libcudart_static.a and cudart_static.lib ship next to cudadevrt in the wheel, conda and CTK layouts, so both use the same search paths.
Contributor
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Shared metadata and lookup validation cuda_pathfinder/cuda/pathfinder/_static_libs/find_static_lib.py, cuda_pathfinder/tests/test_find_static_lib.py |
The shared helper derives platform-specific filenames for both libraries and retains architecture-specific search paths. Tests check metadata and site-packages lookup for cudart_static. |
Suggested labels: cuda.pathfinder, enhancement
Suggested reviewers: isvoid
Priority:
Change: Feature
Merge Risk: 
Minimal · up to beeca
-
No merge-blocking issue is identified for the static-library lookup change; it is ready for normal checks.
Finishing Touches: 💡 1
-
🛠️ Fix failing CI checks: 💡
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
"cudart_static"toSUPPORTED_STATIC_LIBS, solocate_static_lib("cudart_static")andfind_static_lib("cudart_static")findlibcudart_static.a/cudart_static.lib. Today the tuple is only("cudadevrt",).Motivation
Linking the static CUDA runtime lets one extension module work with different CUDA runtimes in the same major. In a CUDA 12 build of a downstream extension library, one
.solinked againstcudart_staticworked in both cuda12 and cuda13 environments (cupy). Today the path has to be passed by hand (-DCUDA_CUDART=<path to libcudart_static.a>).Change
cudart_staticships next tocudadevrtin every layout pathfinder searches, so_cudadevrt_info()becomes_cuda_runtime_static_lib_info(stem)and both entries use it. I checked the layouts directly:nvidia/cu13/lib/nvidia/cuda_runtime/lib/nvidia/cu13/lib/x64/nvidia/cuda_runtime/lib/x64/cuda-cudart-staticlib/lib64/Tests
cudart_staticuses the same search directories ascudadevrton Linux and Windows, and is found in site-packages.site-packages) and a system CTK (CUDA_PATH).