Conversation
cudaq.kernel.utils.emitWarning assembled a formatted warning string into a local `msg` and then fell off the end of the function, discarding it. The only observable effect of a warning was a stray bold-escape sequence with no text, so every advisory routed through this helper (e.g. the non-`slots=True` dataclass notice in mlirTypeFromAnnotation) was silently lost. Its sibling emitWarning in ast_bridge.py ends with `print(msg)`. Print the assembled message so the warning actually reaches the user, and label it "warning:" instead of "error:" to match the function's purpose and the ast_bridge sibling. Signed-off-by: Udaya Tejas <udayatejas2004@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cudaq.kernel.utils.emitWarningnever shows the warning. It formats the diagnostic into a localmsgand then the function ends without printing it, so the only visible effect is a stray bold escape with no text. It also labels the diagnosticerror:even though it is a warning.Root cause
The sibling
PyASTBridge.emitWarninginast_bridge.pyends withprint(msg)and uses awarning:label. This copy dropped the print. The real caller is the non-slots=Truedataclass advisory inutils.py(mlirTypeFromPyType), which users never actually saw.Fix
Print the formatted message, and label it
warning:to match the sibling and the function's purpose.Tests
Added
python/tests/kernel/test_emit_warning.py(capsys): asserts the warning body reaches the user and that the label iswarning:, noterror:.