Fix racecheck in parquet page_string_decode kernels - #23681
Open
davidwendt wants to merge 1 commit into
Open
Conversation
vyasr
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a racecheck found in the weekend compute-sanitizer run in the parquet
page_strings_decode.cukernelstotalDeltaByteArraySizeandcompute_delta_length_page_string_sizes_kernel. Adds awarp.sync()before the call to thesetup_next_mini_block()utility which runs only on warp lane=0.https://github.com/NVIDIA/cudf/actions/runs/31878600604/job/94998078592#step:5:2953
The change was introduced in PR #23314 which rewrote the delta decode loops in
cpp/src/io/parquet/delta_binary.cuhandcpp/src/io/parquet/page_string_decode.cuto decode one warp-size pass at a time. That refactor introduced the pass-by-pass loop pattern intotalDeltaByteArraySizeand theDELTA_LENGTH_BYTE_ARRAYstring-size kernel where all lanes readcurrent_value_idxwithout a synchronizingwarp.sync()before lane 0 advances it insetup_next_mini_block, causing the race.Checklist