Skip to content

Remove CUDA_STATIC_RUNTIME option - #23698

Open
bdice wants to merge 1 commit into
NVIDIA:mainfrom
bdice:remove-cuda-static-runtime-option
Open

Remove CUDA_STATIC_RUNTIME option#23698
bdice wants to merge 1 commit into
NVIDIA:mainfrom
bdice:remove-cuda-static-runtime-option

Conversation

@bdice

@bdice bdice commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Description

Remove the CUDA_STATIC_RUNTIME CMake option from libcudf. All libcudf targets already force static cudart with rapids_cuda_set_runtime(... USE_STATIC ON), so retaining the option is misleading.

Part of rapidsai/build-planning#235.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice
bdice requested a review from a team as a code owner August 18, 2026 00:11
@bdice
bdice requested a review from KyleFromNVIDIA August 18, 2026 00:11
@github-actions github-actions Bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Aug 18, 2026
@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7c5218d4-022f-498c-9b15-736c19a90b10

📥 Commits

Reviewing files that changed from the base of the PR and between 5139e7d and 7ef8539.

📒 Files selected for processing (1)
  • cpp/CMakeLists.txt
💤 Files with no reviewable changes (1)
  • cpp/CMakeLists.txt

Included review availability: Your plan includes up to 12 reviews per rolling hour; 11 remain after this review.


📝 Walkthrough

Summary by CodeRabbit

  • Build Configuration
    • Simplified CUDA linking configuration.
    • NVRTC and nvJitLink now use static linking without the previous runtime selection option.

Walkthrough

Changes

CUDA runtime option cleanup

Layer / File(s) Summary
CMake static-link settings
cpp/CMakeLists.txt
Removes the CUDA_STATIC_RUNTIME option and its assignments. The configuration retains static-link settings for NVRTC and nvJitLink.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to 7ef85

This removes a misleading CMake option without changing libcudf’s existing static CUDA runtime behavior. No actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: kylefromnvidia

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely identifies the removal of the CUDA_STATIC_RUNTIME option, which is the main change.
Description check ✅ Passed The description directly explains why the CUDA_STATIC_RUNTIME option is removed and relates to the changeset.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant