Skip to content

Improve the exception message when cuvs-java is not supported #2495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
imotov wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −7
Open

Improve the exception message when cuvs-java is not supported #2495

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions java/cuvs-java/src/main/java/com/nvidia/cuvs/spi/CuVSServiceProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* SPDX-FileCopyrightText: Copyright (c) 2025, NVIDIA CORPORATION.
* SPDX-FileCopyrightText: Copyright (c) 2025-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
* SPDX-License-Identifier: Apache-2.0
*/
package com.nvidia.cuvs.spi;
Expand Down Expand Up @@ -34,9 +34,12 @@ private static CuVSProvider loadProvider() {
}

static CuVSProvider builtinProvider() {
var supportedJavaRuntime = Runtime.version().feature() > 21;
var supportedOs = System.getProperty("os.name").startsWith("Linux");
var supportedArchitecture = System.getProperty("os.arch").equals("amd64");
var javaRuntimeVersion = Runtime.version().feature();
var osName = System.getProperty("os.name");
var osArch = System.getProperty("os.arch");
var supportedJavaRuntime = javaRuntimeVersion > 21;
var supportedOs = osName.startsWith("Linux");
var supportedArchitecture = osArch.equals("amd64");
if (supportedJavaRuntime && supportedOs && supportedArchitecture) {
try {
var cls = Class.forName("com.nvidia.cuvs.spi.JDKProvider");
Expand All @@ -52,13 +55,15 @@ static CuVSProvider builtinProvider() {
}
List<String> unsupportedReasons = new ArrayList<>();
if (!supportedJavaRuntime) {
unsupportedReasons.add("cuvs-java requires Java Runtime version 22 or greater");
unsupportedReasons.add(
"cuvs-java requires Java Runtime version 22 or greater, but found "
+ javaRuntimeVersion);
}
if (!supportedOs) {
unsupportedReasons.add("cuvs-java supports only Linux");
unsupportedReasons.add("cuvs-java supports only Linux, but os.name is " + osName);
}
if (!supportedArchitecture) {
unsupportedReasons.add("cuvs-java supports only x86");
unsupportedReasons.add("cuvs-java supports only x86-64 (amd64), but os.arch is " + osArch);
}

return new UnsupportedProvider(String.join("; ", unsupportedReasons));
Expand Down
Loading