Backport PR 4338 to Release 2.0 - #4447
Conversation
Description: In FNN mode with an L3 Physical tenant interface (is_l2_segment is false), the FMDS instance metadata gateway address (169.254.169.253/30) was never configured on the DPU in container mode. Root cause: fmds_gateway_vlan is determined by finding the first Physical-typed interface in tenant_interfaces. In FNN deployments, the Physical interface (pf0hpf_if) is typically an L3 linknet, so HasFmdsGateway is true was correctly set on that port. However, nvue_startup_fnn.conf only rendered 169.254.169.253/30 inside the IsL2Segment SVI block. The L3 interface IP block had no equivalent check. Fix: - Added HasFmdsGateway true check to the L3 interface IP block. - Added 3 tests via AI ## Related issues https://nvbugspro.nvidia.com/bug/6533524 ## Type of Change - [ ] **Add** - New feature or capability - [ ] **Change** - Changes in existing functionality - [ x] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.) ## Breaking Changes - [ ] **This PR contains breaking changes** ## Testing - [ ] Unit tests added/updated - [ ] Integration tests added/updated - [ ] Manual testing performed - [ ] No testing required (docs, internal refactor, etc.) ## Additional Notes Don't have a setup for testing, will be tested on demo2 once the fix is in. (cherry picked from commit 1d2f5e5)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🔐 TruffleHog Secret Scan✅ No secrets or credentials found! Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉 🕐 Last updated: 2026-07-31 17:42:37 UTC | Commit: 89c4694 |
🔍 Container Scan Summary
Per-CVE detail lives in the per-service |
1 participant
Backport PR 4338 to Release 2.0.
Related issues
PR 4338
Type of Change
Breaking Changes
Testing
Additional Notes
(cherry picked from commit 1d2f5e5)