fix(devspace): align machine-a-tron configuration with mat-0 pod naming - #4449
Open
pbreton wants to merge 1 commit into
Open
fix(devspace): align machine-a-tron configuration with mat-0 pod naming#4449pbreton wants to merge 1 commit into
pbreton wants to merge 1 commit into
Conversation
Signed-off-by: Patrice Breton <pbreton@nvidia.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
Summary by CodeRabbit
WalkthroughDevspace configuration now uses the Machine-a-Tron ChangesDevspace Machine-a-Tron configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the local DevSpace configuration to use the machine-a-tron chart’s current mat-0 pod naming and generated service name following #3955.
Problem
The machine-a-tron chart now defines its default pod as mat-0, while the DevSpace values still define a pod named default.
Because Helm merges these maps, both pods remain active. Chart validation therefore treats the local deployment as multi-pod and rejects it because mat-k8s-controller is disabled:
multi-pod machine-a-tron deployments require mat-k8s-controller.enabled=true
The chart also suffixes the BMC mock service with the pod name, making the previous unsuffixed service reference invalid.
Changes
Rename the DevSpace machine-a-tron pod override from default to mat-0.
Update the NICo API and BMC proxy configurations to use:
nico-machine-a-tron-mat-0-bmc-mock.nico-system.svc.cluster.local:1266
Update the REST integration check to query the renamed service.
Update the DevSpace documentation with the current service name.
Validation
Rendered the complete parent Helm chart using the DevSpace base and generated values.
Confirmed Helm validation succeeds.
Confirmed exactly one machine-a-tron deployment is rendered.
Confirmed the rendered deployment and service use the mat-0 suffix.
Ran shell syntax and ShellCheck validation on the updated integration script.