Skip to content

fix(devspace): align machine-a-tron configuration with mat-0 pod naming - #4449

Open
pbreton wants to merge 1 commit into
NVIDIA:mainfrom
pbreton:fix/align-devspace-with-new-machine-a-tron-default-pod-name
Open

fix(devspace): align machine-a-tron configuration with mat-0 pod naming#4449
pbreton wants to merge 1 commit into
NVIDIA:mainfrom
pbreton:fix/align-devspace-with-new-machine-a-tron-default-pod-name

Conversation

@pbreton

@pbreton pbreton commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Summary

Update the local DevSpace configuration to use the machine-a-tron chart’s current mat-0 pod naming and generated service name following #3955.

Problem

The machine-a-tron chart now defines its default pod as mat-0, while the DevSpace values still define a pod named default.
Because Helm merges these maps, both pods remain active. Chart validation therefore treats the local deployment as multi-pod and rejects it because mat-k8s-controller is disabled:
multi-pod machine-a-tron deployments require mat-k8s-controller.enabled=true
The chart also suffixes the BMC mock service with the pod name, making the previous unsuffixed service reference invalid.

Changes

Rename the DevSpace machine-a-tron pod override from default to mat-0.
Update the NICo API and BMC proxy configurations to use:
nico-machine-a-tron-mat-0-bmc-mock.nico-system.svc.cluster.local:1266
Update the REST integration check to query the renamed service.
Update the DevSpace documentation with the current service name.

Validation

Rendered the complete parent Helm chart using the DevSpace base and generated values.
Confirmed Helm validation succeeds.
Confirmed exactly one machine-a-tron deployment is rendered.
Confirmed the rendered deployment and service use the mat-0 suffix.
Ran shell syntax and ShellCheck validation on the updated integration script.

Signed-off-by: Patrice Breton <pbreton@nvidia.com>
@pbreton
pbreton requested a review from a team as a code owner July 31, 2026 18:09
@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: adce1feb-b80b-44ee-bf09-5da3b47033cd

📥 Commits

Reviewing files that changed from the base of the PR and between 9f2a546 and c4836e2.

📒 Files selected for processing (3)
  • dev/deployment/devspace/README.md
  • dev/deployment/devspace/setup-rest-integration.sh
  • dev/deployment/devspace/values.base.yaml

Summary by CodeRabbit

  • Documentation

    • Updated local development deployment documentation with the correct Machine-a-Tron BMC mock hostname.
  • Chores

    • Improved deployment setup flexibility by allowing configurable service names.
    • Updated local development configuration to use the Machine-a-Tron service and revised pod naming.

Walkthrough

Devspace configuration now uses the Machine-a-Tron mat-0 pod and MAT BMC mock service. The integration script uses configurable resource names for rollout and status checks. The README documents the updated BMC mock endpoint.

Changes

Devspace Machine-a-Tron configuration

Layer / File(s) Summary
Update MAT-0 resource names and endpoints
dev/deployment/devspace/values.base.yaml
The pod configuration key changes from default to mat-0. The API and BMC proxy endpoints target the MAT BMC mock service.
Wire integration checks to configurable resources
dev/deployment/devspace/setup-rest-integration.sh, dev/deployment/devspace/README.md
The script uses configurable deployment and BMC service names for rollout and status checks. The README documents the updated mock endpoint.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the DevSpace machine-a-tron configuration update and the mat-0 pod naming alignment.
Description check ✅ Passed The description directly explains the machine-a-tron naming issue, configuration changes, and validation results.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant