ci: adopt centralized component workflows - #280
Conversation
Signed-off-by: Alexander Maslennikov <amaslennikov@nvidia.com>
|
| mkdir -p $(CURDIR)/bin | ||
| GOBIN=$(CURDIR)/bin go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@$(GOLANGCILINT_VERSION) | ||
| mv $(CURDIR)/bin/golangci-lint $(GOLANGCI_LINT) |
| $(GOLANGCI_LINT): | ||
| mkdir -p $(CURDIR)/bin | ||
| GOBIN=$(CURDIR)/bin go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@$(GOLANGCILINT_VERSION) | ||
| mv $(CURDIR)/bin/golangci-lint $(GOLANGCI_LINT) |
There was a problem hiding this comment.
make lint now installs a versioned binary under bin/, but that directory is not ignored and make clean does not remove it. Each local installation leaves an untracked build artifact in the checkout. Ignore or clean up the generated binary.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Summary
Validation
Preserves documentation contract checks and all platform builds. Combines race detection and coverage in one test run. Updated CONTRIBUTING.md with CI and local linter installation guidance; operational docs and skills do not describe the changed CI implementation.
Follow-up validation