Skip to content

docs: separate measurement options from stopping criteria#373

Merged
oleksandr-pavlyk merged 1 commit into
NVIDIA:mainfrom
omribz156:codex/docs-measurement-options
May 28, 2026
Merged

docs: separate measurement options from stopping criteria#373
oleksandr-pavlyk merged 1 commit into
NVIDIA:mainfrom
omribz156:codex/docs-measurement-options

Conversation

@omribz156
Copy link
Copy Markdown
Contributor

Summary:

  • Move --timeout and --min-samples under a new Measurement Collection section.
  • Leave Stopping Criteria focused on --stopping-criterion and criterion-specific parameters.

Verification:

  • rg -n "## Measurement Collection|## Stopping Criteria|--timeout|--min-samples|--stopping-criterion" docs/cli_help.md
  • git diff --check

Fixes #366.

This was implemented with Codex assistance, with the final diff manually reviewed and kept to the docs scope.

Signed-off-by: Omri SirComp <omribz156@gmail.com>
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 26, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@oleksandr-pavlyk
Copy link
Copy Markdown
Collaborator

/ok to test a002efc

@oleksandr-pavlyk oleksandr-pavlyk self-requested a review May 28, 2026 21:41
@oleksandr-pavlyk oleksandr-pavlyk added only: docs Documentation changes only. Doesn't need code CI. area: docs Related to documentation. labels May 28, 2026
@oleksandr-pavlyk
Copy link
Copy Markdown
Collaborator

Build documentation locally in the docs branch from #323

image

Copy link
Copy Markdown
Collaborator

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @omribz156

@oleksandr-pavlyk oleksandr-pavlyk merged commit ec025d7 into NVIDIA:main May 28, 2026
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: docs Related to documentation. only: docs Documentation changes only. Doesn't need code CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Doc: timeout and min-samples options do not belong to "Stopping Criteria" section in the docs

2 participants