docs: fix nvidia-container-runtime usage example#1905
Merged
Conversation
Signed-off-by: Billard <82095453+iacker@users.noreply.github.com> Co-authored-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
cdesiniotis
force-pushed
the
docs/fix-runtime-usage-example
branch
from
July 23, 2026 20:51
fdeed4c to
ebf6e57
Compare
Contributor
|
I tried out the new procedure, and hit the below error: I have modified the commit in this PR so that the procedure is functional. @henry118 ptal |
henry118
approved these changes
Jul 23, 2026
henry118
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks for pointing out the TTY issue.
Contributor
|
Thank you @iacker for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the
nvidia-container-runtimeusage example so it follows the runtime path described earlier in the README: the NVIDIA runtime modifies the OCI spec when acreatecommand is detected, then the container can be started.The old example used
run, which skips the modifier path and leaves the generatedconfig.jsonunchanged, as reported in #781.Fixes #781
Validation:
nvidia-container-runtime run nvidia_smiexample is no longer present.create,start, and cleanup withdelete.AI assistance disclosure: