Generate app profile for EGL/Vulkan use case

[henry118]

Fixes #1899

The current CDI/CDI-JIT implementation does not create nvidia application profile in the CDI/JIT-CDI code path.

In the legacy mode, the profile is created when the container has the "graphics/display" capability.

Adding a hook for CDI mode to create the nvidia application profile.

[coveralls]

Coverage Report for CI Build 29937480821

Coverage decreased (-0.2%) to 43.635%

Details

• Coverage decreased (-0.2%) from the base build.
• Patch coverage: 93 uncovered changes across 4 files (17 of 110 lines covered, 15.45%).
• No coverage regressions found.

Uncovered Changes

File	Changed	Covered	%
cmd/nvidia-cdi-hook/update-application-profile/update-application-profile.go	62	13	20.97%
cmd/nvidia-cdi-hook/update-application-profile/minors_linux.go	40	0	0.0%
pkg/nvcdi/common-nvml.go	3	0	0.0%
cmd/nvidia-cdi-hook/commands/commands.go	1	0	0.0%
Total (6 files)	110	17	15.45%

Coverage Regressions

No coverage regressions found.

---

Coverage Stats

Relevant Lines:	15263
Covered Lines:	6660
Line Coverage:	43.63%
Coverage Strength:	0.49 hits per line

---

💛 - Coveralls

[tariq1890]

Thanks @henry118 !

[cdesiniotis]

Potentially for a follow-up -- There may be an opportunity for code reuse here. We are essentially globbing for files in a root. We do this as well in the cudacompat hook, see

nvidia-container-toolkit/cmd/nvidia-cdi-hook/cudacompat/container-root_linux.go

Lines 101 to 138 in 1cddfb0

	func (r root) globFiles(pattern string) ([]string, error) {
	dir := filepath.Dir(pattern)
	basePattern := filepath.Base(pattern)
	d, err := pathrs.OpenatInRoot(r.File, dir)
	if err != nil {
	return nil, err
	}
	defer d.Close()
	dirInRoot, err := pathrs.Reopen(d, unix.O_RDONLY|unix.O_DIRECTORY|unix.O_CLOEXEC)
	if err != nil {
	return nil, err
	}
	defer dirInRoot.Close()
	dEntries, err := dirInRoot.ReadDir(-1)
	if err != nil {
	return nil, fmt.Errorf("failed to get dentries from %q: %w", dir, err)
	}
	var files []string
	dir = strings.TrimPrefix(dirInRoot.Name(), r.Name())
	for _, dentry := range dEntries {
	if match, err := filepath.Match(basePattern, dentry.Name()); err != nil || !match {
	continue
	}
	if dentry.IsDir() {
	continue
	}
	if !dentry.Type().IsRegular() {
	continue
	}
	files = append(files, filepath.Join(dir, dentry.Name()))
	}
	sort.Strings(files)
	return files, nil
	}

. We may benefit from a internal/root package that can be reused by all of our hooks. It should provide the ability to perform file operations "safely" in a root fs.

I was going to suggest we reuse the CharDeviceLocator, from https://github.com/NVIDIA/nvidia-container-toolkit/blob/main/pkg/lookup/device.go, but this code operates on file paths and therefore is not suitable for a hook where we don't trust the root fs we are operating on.

[henry118]

Good suggestion. Let me create another PR for this refactor work to limit its scope.